Coin Brief ENDE

rippled stops sending a peer field no node ever read, and fixes reads lost at database shutdown

Two pull requests merged into rippled, the reference XRP Ledger server, on 9 November tidy up corners of the peer protocol and the shutdown path.

PR 8702 stops sending the receiveTimestamp field of the TMTransaction peer message and marks it deprecated. The pull request gives its history: the field was added on 14 November 2011 so a relaying node could note when it received a transaction. Since 2012 every sender has filled it with its own clock, in four places in the code, and no version of rippled has ever read it. Because peer traffic is encrypted, nothing outside the nodes could read it either. The cost was up to nine bytes on every relayed transaction.

The change is designed to be safe across versions. Older peers still set the field and newer code never read it, so nothing changes on receipt; newer peers simply send less. The peer protocol version stays the same. Marking the field deprecated in the protobuf definition makes the generated accessors deprecated in C++, so any new caller breaks the build, which runs with warnings as errors. Removing the field and reserving its number is left for a later release.

PR 8658 addresses a shutdown problem. Before the fix, when the node store database stopped, reads still waiting in its queue were cleared without their callbacks ever running, and reads requested after the stop did nothing. The caller had no way to know its read was gone. The pull request names one consequence: the SHAMap walk counts the reads it is waiting for, and a single dropped read means the thread running getMissingNodes can block forever. Now each queued read completes with no object, which callers already treat as the signal to abort, and callbacks run after the lock is released. The PR notes the condition is internal shutdown ordering, with no external input involved, and suggests it may explain a hang occasionally seen when stopping the server.

rippled stops sending a peer field no node ever read, and fixes reads lost at database shutdown
rippled stops sending a peer field no node ever read, and fixes reads lost at database shutdown — Coin Brief

Why it matters

Neither change alters transaction processing. Both remove behaviour nobody relied on but everybody paid for: bytes on the wire in one case, a silent dropped callback in the other.

Primary source
XRPLF/rippled on GitHub
https://github.com/XRPLF/rippled/pull/8702
Written by Victoria Shinder.